Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89715546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -590,7 +591,11 @@ object ScalaReflection extends ScalaReflection {
"cannot be used as field name\n" +
walkedTypePath.mkString("\n"))
}
- val fieldValue = Invoke(inputObject, fieldName,
dataTypeFor(fieldType))
+ // primitive take only non-null or struct takes non-null object
guarded by isNull
--- End diff --
I think we can only guarantee that the `inputObject` is not null in the
false case, so we should use `AssertNotNull()` for `inputObject` and the
`fieldValue` will be like:
```scala
val fieldValue = Invoke(
AssertNotNull(inputObject, walkedTypePath), fieldName,
dataTypeFor(fieldType),
returnNullable = !fieldType.typeSymbol.asClass.isPrimitive)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
