Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89721863 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -405,13 +406,14 @@ case class WrapOption(child: Expression, optType: DataType) * A place holder for the loop variable used in [[MapObjects]]. This should never be constructed * manually, but will instead be passed into the provided lambda function. */ -case class LambdaVariable(value: String, isNull: String, dataType: DataType) extends LeafExpression +case class LambdaVariable(value: String, isNull: String, dataType: DataType, + valueNullable: Boolean = true) extends LeafExpression --- End diff -- I meant that we could use the parameter name `nullable` like: ```scala case class LambdaVariable(value: String, isNull: String, dataType: DataType, nullable: Boolean = true) extends LeafExpression ``` and remove `override def nullable: Boolean = valueNullable`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org