Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16009#discussion_r90088312
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends
Params
*
* @group param
*/
- @Since("1.6.0")
--- End diff --
In this case, I think it's OK to have Since annotations in the trait since
it is private and should never be used beyond ChiSqSelector and
ChiSqSelectorModel. That seems pretty safe to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
