Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16009#discussion_r90169879
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -49,15 +49,13 @@ private[feature] trait ChiSqSelectorParams extends
Params
*
* @group param
*/
- @Since("1.6.0")
--- End diff --
Yeah, it's safe for this case. However, I found lots of other traits which
is also safe enough to add since tag but did not add. I reverted this part of
change in this PR to make it catch another RC of 2.1, I think we should unify
them in a separate work. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
