Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15505#discussion_r93078511
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
    @@ -139,29 +139,6 @@ class TaskSchedulerImplSuite extends SparkFunSuite 
with LocalSparkContext with B
         assert(!failedTaskSet)
       }
     
    -  test("Scheduler does not crash when tasks are not serializable") {
    --- End diff --
    
    If I understand right, you are saying there are now test cases which cover 
all of the little individual pieces inside a `Task`, so we don't need an 
explicit test for the serializing the entire task.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to