Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r93558431
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -232,6 +225,13 @@ private[spark] class Executor(
}
override def run(): Unit = {
+ val taskId = taskDesc.taskId
+ val attemptNumber = taskDesc.attemptNumber
+ val taskName = taskDesc.name
+ val taskFiles = taskDesc.taskFiles
+ val taskJars = taskDesc.taskJars
+ val taskProps = taskDesc.taskProperties
--- End diff --
If use `taskDesc.taskId`, we need to modify a lot of code. eg:
```scala
val errMsg =
s"${releasedLocks.size} block locks were not released by TID
= $taskId:\n" +
releasedLocks.mkString("[", ", ", "]")
```
The length of this line of `s"${releasedLocks.size} block locks were not
released by TID = ${taskDesc.taskId}:\n"` is greater than 100
How do I move the code to:
```scala
class TaskRunner(
execBackend: ExecutorBackend,
val taskDesc: TaskDescription)
extends Runnable {
val taskId = taskDesc.taskId
val attemptNumber = taskDesc.attemptNumber
val taskName = taskDesc.name
val taskFiles = taskDesc.taskFiles
val taskJars = taskDesc.taskJars
val taskProps = taskDesc.taskProperties
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
