Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15505#discussion_r93558450
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -993,6 +993,12 @@ class DAGScheduler(
               JavaUtils.bufferToArray(closureSerializer.serialize((stage.rdd, 
stage.func): AnyRef))
           }
     
    +      if (taskBinaryBytes.length > TaskSetManager.TASK_SIZE_TO_WARN_KB * 
1024) {
    --- End diff --
    
     
    The original code version seems to be warning about full task, including 
rdd, shuffle dep, closures, partition and so on.
    I think that the previous warning code was retained because the #1498 did 
not completely modify it,
    In most cases, the size of  serialized TaskDescription is smaller than 
tasks`s Broadcast.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to