Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94716683
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -172,6 +187,8 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper] {
model,
ldaModel.logLikelihood(preprocessedData),
ldaModel.logPerplexity(preprocessedData),
+ trainingLogLikelihood,
+ logPrior,
--- End diff --
since model is referenced and persisted, is there a need to handle
trainingLogLikelihood and logPrior separately like this, and writing to
metadata, instead of just getting from the model when fetching for the summary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
