Github user wangmiao1981 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16464#discussion_r94721880
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
    @@ -172,6 +187,8 @@ private[r] object LDAWrapper extends 
MLReadable[LDAWrapper] {
           model,
           ldaModel.logLikelihood(preprocessedData),
           ldaModel.logPerplexity(preprocessedData),
    +      trainingLogLikelihood,
    +      logPrior,
    --- End diff --
    
    The first version, I got them from the model in the `LDAWrapper` class. 
However, when I read `logPrior`, I found that the loaded `logPrior` is not the 
same as the value before save. So, I followed the logLikelihood and 
logPerplexity to save it in the metadata. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to