Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r94867743
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +66,39 @@ class GBTClassifierSuite extends SparkFunSuite with
MLlibTestSparkContext
ParamsSuite.checkParams(new GBTClassifier)
val model = new GBTClassificationModel("gbtc",
Array(new DecisionTreeRegressionModel("dtr", new LeafNode(0.0, 0.0,
null), 1)),
- Array(1.0), 1)
+ Array(1.0), 1, 2)
ParamsSuite.checkParams(model)
}
+ test("Verify raw scores correspond to labels") {
--- End diff --
Could you take a look at [this
test](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala#L314),
and make it line up here? Specifically:
* compute probabilities manually from rawPrediction and ensure that it
matches the probabilities column
* make sure that probabilities.argmax and rawPrediction.argmax equal the
prediction
* make sure probabilities sum to one
* check the different code paths by unsetting some of the output columns
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
