Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/16441#discussion_r94857458 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala --- @@ -248,12 +269,38 @@ class GBTClassificationModel private[ml]( if (prediction > 0.0) 1.0 else 0.0 } + override protected def predictRaw(features: Vector): Vector = { + val treePredictions = _trees.map(_.rootNode.predictImpl(features).prediction) + val prediction = blas.ddot(numTrees, treePredictions, 1, _treeWeights, 1) --- End diff -- We should import `org.apache.spark.ml.linalg.BLAS` and call `BLAS.dot` here and in `predict`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org