Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r94868112
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -248,12 +269,38 @@ class GBTClassificationModel private[ml](
if (prediction > 0.0) 1.0 else 0.0
}
+ override protected def predictRaw(features: Vector): Vector = {
--- End diff --
In logistic regression we had previously overridden some of the methods in
probabilistic classifier since we were only dealing with two classes, which
makes those methods a bit faster (hard to say how much). We can do it here for
now, but I'd be slightly in favor of _not_ doing it since I'm not sure how much
we gain from it and it makes the code harder to follow. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
