Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/16722#discussion_r98599006 --- Diff: mllib-local/src/test/scala/org/apache/spark/ml/util/TestingUtils.scala --- @@ -48,7 +48,7 @@ object TestingUtils { /** * Private helper function for comparing two values using absolute tolerance. */ - private def AbsoluteErrorComparison(x: Double, y: Double, eps: Double): Boolean = { + private[ml] def AbsoluteErrorComparison(x: Double, y: Double, eps: Double): Boolean = { --- End diff -- I don't see this used in the new code, maybe my search is not working properly in browser
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org