Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98599033
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/util/TestingUtils.scala ---
@@ -31,7 +31,7 @@ object TestingUtils {
* Note that if x or y is extremely close to zero, i.e., smaller than
Double.MinPositiveValue,
* the relative tolerance is meaningless, so the exception will be
raised to warn users.
*/
- private def RelativeErrorComparison(x: Double, y: Double, eps: Double):
Boolean = {
+ private[ml] def RelativeErrorComparison(x: Double, y: Double, eps:
Double): Boolean = {
--- End diff --
might it be better to just make this public, if we are using it in tests,
similar to other test methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
