Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16722#discussion_r98600282
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
 ---
    @@ -126,20 +127,22 @@ class RandomForestClassifier @Since("1.4.0") (
             s" numClasses=$numClasses, but thresholds has length 
${$(thresholds).length}")
         }
     
    -    val oldDataset: RDD[LabeledPoint] = extractLabeledPoints(dataset, 
numClasses)
    +    val instances = dataset.select(col($(labelCol)).cast(DoubleType), 
col($(featuresCol))).rdd.map {
    +      case Row(label: Double, features: Vector) => Instance(label, 1.0, 
features)
    --- End diff --
    
    it looks like we aren't getting the weight column here; not sure why this 
file needed to be changed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to