Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16938#discussion_r103018002
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -140,8 +140,8 @@ case class CreateDataSourceTableAsSelectCommand(
return Seq.empty
}
- saveDataIntoTable(
- sparkSession, table, table.storage.locationUri, query, mode,
tableExists = true)
+ saveDataIntoTable(sparkSession, table, table.storage.locationUri,
query, mode,
--- End diff --
we should also explain the behavior in the PR description: When path
already exists, we should append to it or overwrite it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
