Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16938#discussion_r103093397
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -140,8 +140,8 @@ case class CreateDataSourceTableAsSelectCommand(
return Seq.empty
}
- saveDataIntoTable(
- sparkSession, table, table.storage.locationUri, query, mode,
tableExists = true)
+ saveDataIntoTable(sparkSession, table, table.storage.locationUri,
query, mode,
--- End diff --
`CreateTableAsSelectCommand` overwrite table path or not has no relation
with the `SaveMode` of CTAS, that is if the table has already exist, we will
overwrite it whatever the SaveMode is except that we should still check the
path if exists for a managed(another
[PR](https://github.com/apache/spark/pull/17057) to resolve this), so I think
overwrite can't be replaced by SaveMode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
