Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16938#discussion_r103419011
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -151,7 +151,7 @@ case class CreateDataSourceTableAsSelectCommand(
table.storage.locationUri
}
val result = saveDataIntoTable(
- sparkSession, table, tableLocation, query, mode, tableExists =
false)
+ sparkSession, table, tableLocation, query, mode, overwrite = true,
tableExists = false)
--- End diff --
in this branch, table not exist, and the expected behavior is to create a
directory or overwrite it if it's already existed. So we can just pass a
`OverWrite` mode here, and everything should work. Did I miss something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
