Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17401#discussion_r108120305
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
@@ -166,6 +170,23 @@ protected void serviceInit(Configuration conf) throws
Exception {
TransportConf transportConf = new TransportConf("shuffle", new
HadoopConfigProvider(conf));
blockHandler = new ExternalShuffleBlockHandler(transportConf,
registeredExecutorFile);
+ // register metrics on the block handler into the Node Manager's
metrics system.
+ try {
+ YarnShuffleServiceMetrics serviceMetrics = new
YarnShuffleServiceMetrics(
+ blockHandler.getAllMetrics());
+ MetricsSystemImpl metricsSystem = (MetricsSystemImpl)
DefaultMetricsSystem.instance();
+
+ Method registerSourceMethod =
metricsSystem.getClass().getDeclaredMethod("registerSource",
+ String.class, String.class, MetricsSource.class);
--- End diff --
Nit, here I think should be 2 space indent follow the previous line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
