Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17401#discussion_r109918033
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.network.yarn;
+
+import com.codahale.metrics.*;
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.hadoop.metrics2.MetricsCollector;
+import org.apache.hadoop.metrics2.MetricsInfo;
+import org.apache.hadoop.metrics2.MetricsRecordBuilder;
+import org.apache.hadoop.metrics2.MetricsSource;
+
+import java.util.Map;
+
+/**
+ * Modeled off of YARN's NodeManagerMetrics.
+ */
+public class YarnShuffleServiceMetrics implements MetricsSource {
+
+ private final MetricSet metricSet;
+
+ public YarnShuffleServiceMetrics(MetricSet metricSet) {
+ this.metricSet = metricSet;
+ }
+
+ /**
+ * Get metrics from the source
+ *
+ * @param collector to contain the resulting metrics snapshot
+ * @param all if true, return all metrics even if unchanged.
+ */
+ @Override
+ public void getMetrics(MetricsCollector collector, boolean all) {
+ MetricsRecordBuilder metricsRecordBuilder =
collector.addRecord("shuffleService");
+
+ for (Map.Entry<String, Metric> entry :
metricSet.getMetrics().entrySet()) {
+ collectMetric(metricsRecordBuilder, entry.getKey(),
entry.getValue());
+ }
+ }
+
+ @VisibleForTesting
+ public static void collectMetric(MetricsRecordBuilder
metricsRecordBuilder, String name, Metric metric) {
+
+ // The metric types used in ExternalShuffleBlockHandler.ShuffleMetrics
+ if (metric instanceof Timer) {
+ Timer t = (Timer) metric;
+ metricsRecordBuilder
+ .addCounter(new ShuffleServiceMetricsInfo(name + "_count", "Count
of timer " + name),
+ t.getCount())
+ .addGauge(
+ new ShuffleServiceMetricsInfo(name + "_rate15", "15 minute rate
of timer " + name),
+ t.getFifteenMinuteRate())
+ .addGauge(
+ new ShuffleServiceMetricsInfo(name + "_rate5", "5 minute rate of
timer " + name),
+ t.getFiveMinuteRate())
+ .addGauge(
+ new ShuffleServiceMetricsInfo(name + "_rate1", "1 minute rate of
timer " + name),
+ t.getOneMinuteRate())
+ .addGauge(new ShuffleServiceMetricsInfo(name + "_rateMean", "Mean
rate of timer " + name),
+ t.getMeanRate());
+ } else if (metric instanceof Meter) {
+ Meter m = (Meter) metric;
+ metricsRecordBuilder
+ .addCounter(new ShuffleServiceMetricsInfo(name + "_count", "Count
of meter " + name),
+ m.getCount())
+ .addGauge(
+ new ShuffleServiceMetricsInfo(name + "_rate15", "15 minute rate
of meter " + name),
+ m.getFifteenMinuteRate())
+ .addGauge(
+ new ShuffleServiceMetricsInfo(name + "_rate5", "5 minute rate of
meter " + name),
+ m.getFiveMinuteRate())
+ .addGauge(
+ new ShuffleServiceMetricsInfo(name + "_rate1", "1 minute rate of
meter " + name),
+ m.getOneMinuteRate())
+ .addGauge(new ShuffleServiceMetricsInfo(name + "_rateMean", "Mean
rate of meter " + name),
+ m.getMeanRate());
+ } else if (metric instanceof Gauge) {
+ Gauge m = (Gauge) metric;
+ Object gaugeValue = m.getValue();
+ if (gaugeValue instanceof Integer) {
+ Integer intValue = (Integer) gaugeValue;
--- End diff --
Does it mean that we could only handle integer Gauge, what if later on we
add different metric in `ExternalShuffleBlockHandler`? Looks like we should
also manually handle the case one by one here. At least we should an else
branch for the fallback check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
