Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17401#discussion_r109914191
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -176,7 +176,8 @@ private void checkAuth(TransportClient client, String
appId) {
/**
* A simple class to wrap all shuffle service wrapper metrics
*/
- private class ShuffleMetrics implements MetricSet {
+ @VisibleForTesting
--- End diff --
`@VisibleForTesting` causes classpath issues. Please note this in the java
doc instead (SPARK-11615).
This is a scalastyle output, would be better to remove this annotation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
