Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17495#discussion_r110722790
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -320,14 +321,15 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
.filter { entry =>
try {
val prevFileSize =
fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+ fs.access(entry.getPath, FsAction.READ)
--- End diff --
So, this API actually calls `fs.getFileStatus()` which is a remote call and
completely unnecessary in this context, since you already have the `FileStatus`.
You could instead directly do the check against the `FsPermission` object
(same way the `fs.access()` does after it performs the remote call).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
