Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17658#discussion_r114910835
  
    --- Diff: 
core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json
 ---
    @@ -22,6 +23,7 @@
         "duration" : 101795,
         "sparkUser" : "jose",
         "completed" : true,
    +    "appSparkVersion" : "",
    --- End diff --
    
    This doesn't look correct. If I look at the log file for this app 
(`core/src/test/resources/spark-events/app-20161115172038-0000`), there's a log 
start event:
    
    ```
    {"Event":"SparkListenerLogStart","Spark Version":"2.1.0-SNAPSHOT"}
    ```
    
    So this value should be `"2.1.0-SNAPSHOT"`, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to