Github user redsanket commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17658#discussion_r115096536
  
    --- Diff: 
core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json
 ---
    @@ -22,6 +23,7 @@
         "duration" : 101795,
         "sparkUser" : "jose",
         "completed" : true,
    +    "appSparkVersion" : "",
    --- End diff --
    
    I see events being passed to ApplicationEventListener in debug logs but 
interestingly I doPostEvent seems to be not posting events to the listener to 
listen to the event which is a bit odd, not sure I need to add a change in 
contract for the tests to pick this up though
    
    17/05/05 16:39:42.235 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.jobs.JobProgressListener@53e58df 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:42.235 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.env.EnvironmentListener@53371e87 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:42.235 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.storage.StorageStatusListener@394665e7 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:42.235 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.exec.ExecutorsListener@2d92f38e 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:42.235 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.storage.StorageListener@5a9dbe43 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:42.235 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.scope.RDDOperationGraphListener@31b550b1 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:42.236 qtp1618269752-1127 INFO ReplayListenerBus: listener 
--- event org.apache.spark.scheduler.ApplicationEventListener@3b56723d 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.jobs.JobProgressListener@3647a865 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.env.EnvironmentListener@4357e8cc 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.storage.StorageStatusListener@5062f4c0 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.exec.ExecutorsListener@273c097f 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.storage.StorageListener@2c33997d 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.scope.RDDOperationGraphListener@505e15bf 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:43.300 qtp1618269752-1126 INFO ReplayListenerBus: listener 
--- event org.apache.spark.scheduler.ApplicationEventListener@175d3f80 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.jobs.JobProgressListener@71dacceb 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.env.EnvironmentListener@6f41235c 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.storage.StorageStatusListener@3cdcb6d0 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.exec.ExecutorsListener@4abcd5c6 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.storage.StorageListener@6d26f5ee 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.scope.RDDOperationGraphListener@b1b60d5 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.305 qtp1618269752-1131 INFO ReplayListenerBus: listener 
--- event org.apache.spark.scheduler.ApplicationEventListener@52283d50 
---SparkListenerLogStart(2.3.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.jobs.JobProgressListener@f1563e7 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.env.EnvironmentListener@9122315 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.storage.StorageStatusListener@eb98c21 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.exec.ExecutorsListener@1da79f75 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.storage.StorageListener@3989cd7d 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.scope.RDDOperationGraphListener@219b4bd2 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.676 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.scheduler.ApplicationEventListener@63811344 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.722 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.jobs.JobProgressListener@52177d75 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.722 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.env.EnvironmentListener@72409b15 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.722 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.storage.StorageStatusListener@5ee11505 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.722 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.exec.ExecutorsListener@24bad915 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.722 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.storage.StorageListener@4d2fe422 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.723 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.ui.scope.RDDOperationGraphListener@3bc156a1 
---SparkListenerLogStart(1.4.0-SNAPSHOT)
    17/05/05 16:39:44.723 qtp1478318899-1195 INFO ReplayListenerBus: listener 
--- event org.apache.spark.scheduler.ApplicationEventListener@6d5e35e1 
---SparkListenerLogStart(1.4.0-SNAPSHOT)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to