Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17658#discussion_r115097193
  
    --- Diff: 
core/src/test/resources/HistoryServerExpectations/completed_app_list_json_expectation.json
 ---
    @@ -22,6 +23,7 @@
         "duration" : 101795,
         "sparkUser" : "jose",
         "completed" : true,
    +    "appSparkVersion" : "",
    --- End diff --
    
    I think I know what this is. `FsHistoryProvider` has this code to speed up 
the log parsing for listings:
    
    ```
      protected def mergeApplicationListing(fileStatus: FileStatus): Unit = {
        val newAttempts = try {
          val eventsFilter: ReplayEventsFilter = { eventString =>
            eventString.startsWith(APPL_START_EVENT_PREFIX) ||
              eventString.startsWith(APPL_END_EVENT_PREFIX)
          }
    ```
    
    It only allows those two events through currently, you probably need to the 
log start event to that list too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to