Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18000#discussion_r117143908
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -166,7 +166,14 @@ private[parquet] object ParquetFilters {
* Converts data sources filters to Parquet filter predicates.
*/
def createFilter(schema: StructType, predicate: sources.Filter):
Option[FilterPredicate] = {
- val dataTypeOf = getFieldMap(schema)
+ val nameTypeMap = getFieldMap(schema)
+
+ // Parquet does not allow dots in the column name because dots are
used as a column path
--- End diff --
Hm, I expect this is a non-critical path and not executed multiple times.
Also, it does not look particularly faster to call, `Filter.references` ->
`Filter.findReferences` -> `Filter.references` ... . Another downside (maybe
nitpicking) is, this will introduce another small code path that returns `None`
for filter creation failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
