Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18000#discussion_r117162950
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -47,39 +49,47 @@ import org.apache.spark.util.{AccumulatorContext,
AccumulatorV2}
* data type is nullable.
*/
class ParquetFilterSuite extends QueryTest with ParquetTest with
SharedSQLContext {
--- End diff --
can we just have a simple end-to-end test? The fix is actually very simple
and seems not worth such complex tests to verify it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
