Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18000#discussion_r117158402
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -490,6 +516,42 @@ class ParquetFilterSuite extends QueryTest with
ParquetTest with SharedSQLContex
}
}
+ test("SPARK-20364 Do not push down filters when column names have dots")
{
+ implicit class StringToAttribute(str: String) {
+ // Implicits for attr, $ and symbol do not handle backticks.
+ def attribute: Attribute = UnresolvedAttribute.quotedString(str)
--- End diff --
Yea, actually my initial version in my local included the change for
`symbol` and` $` to match them to `Column`. It also looks making sense per
https://github.com/apache/spark/pull/7969. I believe this is an internal API -
https://github.com/apache/spark/blob/e9c91badce64731ffd3e53cbcd9f044a7593e6b8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/package.scala#L24
so I guess it would be fine even if it introduces a behaviour change.
Nevertheless, I believe some guys don't like this change much and wanted to
avoid such changes here for now (it is single place it needs anyway for now ...
).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
