Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18164#discussion_r119808932 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None): +---+------+-------+ """ if not isinstance(value, (float, int, long, basestring, dict)): - raise ValueError("value should be a float, int, long, string, or dict") + raise ValueError("value should be a float, int, long, string, boolean or dict") - if isinstance(value, (int, long)): + if isinstance(value, bool): + pass + elif isinstance(value, (int, long)): --- End diff -- Could we just make this `not isinstance(value, bool) and isinstance(value, (int, long))` (maybe with a small comment)?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org