Github user rberenguel commented on a diff in the pull request:
https://github.com/apache/spark/pull/18164#discussion_r119812590
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1303,9 +1312,11 @@ def fillna(self, value, subset=None):
+---+------+-------+
"""
if not isinstance(value, (float, int, long, basestring, dict)):
--- End diff --
I omitted it just because it wasn't failing for this if, but indeed, I'm a
bit more on the side of putting it in even if just for completeness. Makes
reading the code much saner if we have the if for bool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
