Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18164#discussion_r119810649
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -36,6 +36,15 @@ class DataFrameNaFunctionsSuite extends QueryTest with
SharedSQLContext {
).toDF("name", "age", "height")
}
+ def createBooleanDF(): DataFrame = {
--- End diff --
It looks this functions is only used once. I think we could just move the
lines in the functions into the test, "fill".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
