Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18235#discussion_r123870719
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -752,25 +793,35 @@ class SparkSubmitSuite
test("downloadFile - invalid url") {
intercept[IOException] {
- SparkSubmit.downloadFile("abc:/my/file", new Configuration())
+ val sparkConf = new SparkConf()
--- End diff --
Should we create a `testDownloadFile()` function and merge the duplicated
test code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
