Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18235#discussion_r123932628
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -310,33 +310,28 @@ object SparkSubmit extends CommandLineUtils {
RPackageUtils.checkAndBuildRPackage(args.jars, printStream,
args.verbose)
}
- // In client mode, download remote files.
- if (deployMode == CLIENT) {
- val hadoopConf = new HadoopConfiguration()
- args.primaryResource =
Option(args.primaryResource).map(downloadFile(_, hadoopConf)).orNull
- args.jars = Option(args.jars).map(downloadFileList(_,
hadoopConf)).orNull
- args.pyFiles = Option(args.pyFiles).map(downloadFileList(_,
hadoopConf)).orNull
- args.files = Option(args.files).map(downloadFileList(_,
hadoopConf)).orNull
- }
+ val hadoopConf = new HadoopConfiguration()
+ val targetDir = Files.createTempDirectory("tmp").toFile
+ val sparkConf = new SparkConf(loadDefaults =
false).setAll(args.sparkProperties)
--- End diff --
@vanzin yes, your concern is correct. `Logging` module will be initialized
by other class, thus default log level constraint is broken.
The purpose here is to use `Utils.doFetchFile` without duplication. One
solution I could think of is to add the similar code here to avoid logging
initialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
