Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18235#discussion_r123870610
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -845,32 +840,54 @@ object SparkSubmit extends CommandLineUtils {
*/
private[deploy] def downloadFileList(
fileList: String,
+ targetDir: File,
+ sparkConf: SparkConf,
+ securityManager: SecurityManager,
hadoopConf: HadoopConfiguration): String = {
require(fileList != null, "fileList cannot be null.")
- fileList.split(",").map(downloadFile(_, hadoopConf)).mkString(",")
+ fileList.split(",")
+ .map(downloadFile(_, targetDir, sparkConf, securityManager,
hadoopConf))
+ .mkString(",")
}
/**
* Download a file from the remote to a local temporary directory. If
the input path points to
* a local path, returns it with no operation.
*/
- private[deploy] def downloadFile(path: String, hadoopConf:
HadoopConfiguration): String = {
+ private[deploy] def downloadFile(
+ path: String,
+ targetDir: File,
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
