Github user mbasmanova commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18421#discussion_r124546295
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -95,25 +95,32 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder(conf) {
        * {{{
        *   ANALYZE TABLE table COMPUTE STATISTICS [NOSCAN];
        * }}}
    +   * Example SQL for analyzing a single partition :
    +   * {{{
    +   *   ANALYZE TABLE table PARTITION (key=value,..) COMPUTE STATISTICS 
[NOSCAN];
    --- End diff --
    
    I'm seeing that visitNonOptionalPartitionSpec detects unset partition 
columns and throws an exception: Found an empty partition key '$key'. Is this 
sufficient or do you have something else in mind?
    
    /**
       * Create a partition specification map without optional values.
       */
      protected def visitNonOptionalPartitionSpec(
          ctx: PartitionSpecContext): Map[String, String] = withOrigin(ctx) {
        visitPartitionSpec(ctx).map {
          case (key, None) => throw new ParseException(s"Found an empty 
partition key '$key'.", ctx)
          case (key, Some(value)) => key -> value
        }
      }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to