Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18428#discussion_r125175405
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/TrainValidationSplitSuite.scala
---
@@ -160,8 +213,21 @@ class TrainValidationSplitSuite
}
}
-object TrainValidationSplitSuite {
-
+object TrainValidationSplitSuite extends SparkFunSuite{
+ /**
+ * Assert sequences of estimatorParamMaps are identical.
+ * Params must be simple types comparable with `===`.
+ */
+ def compareParamMaps(pMaps: Array[ParamMap], pMaps2: Array[ParamMap]):
Unit = {
--- End diff --
If this is the same as in CrossValidatorSuite, then can you please move
them to a shared file (maybe ValidatorParamsSuite)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
