Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18428#discussion_r125175232
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/TrainValidationSplitSuite.scala
---
@@ -134,6 +134,59 @@ class TrainValidationSplitSuite
assert(tvs.getTrainRatio === tvs2.getTrainRatio)
assert(tvs.getSeed === tvs2.getSeed)
+
+ TrainValidationSplitSuite
+ .compareParamMaps(tvs.getEstimatorParamMaps,
tvs2.getEstimatorParamMaps)
+
+ tvs2.getEstimator match {
+ case lr2: LogisticRegression =>
+ assert(lr.uid === lr2.uid)
+ assert(lr.getMaxIter === lr2.getMaxIter)
+ case other =>
+ throw new AssertionError(s"Loaded TrainValidationSplit expected
estimator of type" +
+ s" LogisticRegression but found ${other.getClass.getName}")
+ }
+ }
+
+ test("read/write: TrainValidationSplit with nested estimator") {
+ val ova = new OneVsRest()
+ .setClassifier(new LogisticRegression)
+ val evaluator = new BinaryClassificationEvaluator()
+ .setMetricName("areaUnderPR") // not default metric
+ val classifier1 = new LogisticRegression().setRegParam(2.0)
+ val classifier2 = new LogisticRegression().setRegParam(3.0)
+ val paramMaps = new ParamGridBuilder()
+ .addGrid(ova.classifier, Array(classifier1, classifier2))
+ .build()
+ val tvs = new TrainValidationSplit()
+ .setEstimator(ova)
+ .setEvaluator(evaluator)
+ .setTrainRatio(0.5)
+ .setEstimatorParamMaps(paramMaps)
+ .setSeed(42L)
+
+ val tvs2 = testDefaultReadWrite(tvs, testParams = false)
+
+ assert(tvs.getTrainRatio === tvs2.getTrainRatio)
+ assert(tvs.getSeed === tvs2.getSeed)
+
+ tvs2.getEstimator match {
+ case ova2: OneVsRest =>
+ assert(ova.uid === ova2.uid)
+ val classifier = ova2.getClassifier
+ classifier match {
+ case lr: LogisticRegression =>
+
assert(ova.getClassifier.asInstanceOf[LogisticRegression].getMaxIter
+ === lr.asInstanceOf[LogisticRegression].getMaxIter)
--- End diff --
lr is already of type LogisticRegression (no need to cast)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
