Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18428#discussion_r125176348
--- Diff: python/pyspark/ml/tuning.py ---
@@ -263,8 +301,60 @@ def copy(self, extra=None):
newCV.setEvaluator(self.getEvaluator().copy(extra))
return newCV
+ @since("2.3.0")
+ def write(self):
+ """Returns an MLWriter instance for this ML instance."""
+ return JavaMLWriter(self)
+
+ @since("2.3.0")
+ def save(self, path):
+ """Save this ML instance to the given path, a shortcut of
`write().save(path)`."""
+ self.write().save(path)
+
+ @classmethod
+ @since("2.3.0")
+ def read(cls):
+ """Returns an MLReader instance for this class."""
+ return JavaMLReader(cls)
+
+ @classmethod
+ @since("2.3.0")
--- End diff --
Don't add since annotations to private methods
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
