Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18966#discussion_r134134190 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -582,6 +582,15 @@ object SQLConf { .intConf .createWithDefault(2667) + val CODEGEN_MAX_CHARS_PER_FUNCTION = buildConf("spark.sql.codegen.maxCharactersPerFunction") --- End diff -- If the length of source code does not mean the number of lines of the source code, you are right. This is because we check the sum of [`String.length`](https://github.com/apache/spark/pull/18966/files#diff-8bcc5aea39c73d4bf38aef6f6951d42cR785). Here are two examples. ```abc``` -> 3 ``` ab c ``` -> 4
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org