Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19307#discussion_r140211444
  
    --- Diff: external/kafka-0-10-sql/pom.xml ---
    @@ -102,8 +102,19 @@
         </dependency>
     
       </dependencies>
    +
       <build>
         
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
         
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
       </build>
    +
    +  <profiles>
    +    <profile>
    +      <id>scala-2.12</id>
    +      <properties>
    +        <kafka.version>0.10.1.1</kafka.version>
    --- End diff --
    
    Only 0.10.1+ supports Scala 2.12. By the time a 2.12 build is actually 
supported we may be on to 0.10.2. Not sure. This at least makes it work


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to