Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19307#discussion_r140210654
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -218,11 +218,13 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
if (!conf.contains("spark.testing")) {
// A task that periodically checks for event log updates on disk.
logDebug(s"Scheduling update thread every $UPDATE_INTERVAL_S
seconds")
- pool.scheduleWithFixedDelay(getRunner(checkForLogs), 0,
UPDATE_INTERVAL_S, TimeUnit.SECONDS)
+ pool.scheduleWithFixedDelay(
+ getRunner(() => checkForLogs()), 0, UPDATE_INTERVAL_S,
TimeUnit.SECONDS)
--- End diff --
These changes avoid warnings about eta-expansion of zero-arg methods. It
works fine in 2.11 as well; just not relying on syntactic sugar for the same.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
