Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19307#discussion_r140210769
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -450,10 +450,9 @@ private[deploy] class Worker(
             }
           }(cleanupThreadExecutor)
     
    -      cleanupFuture.onFailure {
    -        case e: Throwable =>
    -          logError("App dir cleanup failed: " + e.getMessage, e)
    -      }(cleanupThreadExecutor)
    +      cleanupFuture.failed.foreach(e =>
    --- End diff --
    
    onFailure, onSuccess are deprecated in 2.12. This should be equivalent in 
2.11+2.12


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to