Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19307#discussion_r140211172
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala ---
    @@ -83,11 +83,12 @@ class SparkSubmitUtilsSuite extends SparkFunSuite with 
BeforeAndAfterAll {
         val resolver = settings.getDefaultResolver.asInstanceOf[ChainResolver]
         assert(resolver.getResolvers.size() === 4)
         val expected = repos.split(",").map(r => s"$r/")
    -    resolver.getResolvers.toArray.zipWithIndex.foreach { case (resolver: 
AbstractResolver, i) =>
    -      if (1 < i && i < 3) {
    -        assert(resolver.getName === s"repo-$i")
    -        assert(resolver.asInstanceOf[IBiblioResolver].getRoot === 
expected(i - 1))
    -      }
    +    
resolver.getResolvers.toArray.map(_.asInstanceOf[AbstractResolver]).zipWithIndex.foreach
 {
    --- End diff --
    
    This ends up being interpreted as a partial function, which wasn't the 
intent, and generates a warning. Should be equivalent


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to