Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19389#discussion_r141999620
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala
 ---
    @@ -249,6 +249,11 @@ class ParquetPartitionDiscoverySuite extends QueryTest 
with ParquetTest with Sha
               true,
               rootPaths,
               timeZoneId)
    +      assert(actualSpec.partitionColumns === spec.partitionColumns)
    +      assert(actualSpec.partitions.length === spec.partitions.length)
    +      actualSpec.partitions.zip(spec.partitions).foreach { case (actual, 
expected) =>
    +        assert(actual === expected)
    +      }
    --- End diff --
    
    Yes, it is. It was difficult for me to find which one was different.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to