Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19389#discussion_r142000068
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala
---
@@ -1067,4 +1098,24 @@ class ParquetPartitionDiscoverySuite extends
QueryTest with ParquetTest with Sha
checkAnswer(spark.read.load(path.getAbsolutePath), df)
}
}
+
+ test("Resolve type conflicts - decimals, dates and timestamps in
partition column") {
+ withTempPath { path =>
+ val df = Seq((1, "2015-01-01"), (2, "2016-01-01
00:01:00")).toDF("i", "ts")
+
df.write.format("parquet").partitionBy("ts").save(path.getAbsolutePath)
--- End diff --
I think `2016-01-01 00:01:00` was placed when calling
`resolveTypeConflicts`. Let me try to make this test case not dependent on
this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
