Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18732#discussion_r142524349
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
 ---
    @@ -44,14 +63,22 @@ case class ArrowEvalPythonExec(udfs: Seq[PythonUDF], 
output: Seq[Attribute], chi
         val schemaOut = 
StructType.fromAttributes(output.drop(child.output.length).zipWithIndex
           .map { case (attr, i) => attr.withName(s"_$i") })
     
    +    val batchSize = conf.arrowMaxRecordsPerBatch
    +
    +    val batchIter = if (batchSize > 0) {
    +      new BatchIterator(iter, batchSize)
    +    } else {
    +      Iterator(iter)
    +    }
    --- End diff --
    
    This could be done on one line, not sure if others agree with that style 
though


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to