Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r142533141
--- Diff: python/pyspark/sql/functions.py ---
@@ -2058,7 +2058,7 @@ def __init__(self, func, returnType, name=None,
vectorized=False):
self._name = name or (
func.__name__ if hasattr(func, '__name__')
else func.__class__.__name__)
- self._vectorized = vectorized
+ self.vectorized = vectorized
--- End diff --
I kind of dislike the inconsistency between `UserDefinedFunction` and its
wrapped function. I think they are just the same thing except for the wrapped
function has doc string. For ease of mind, I think we should make them either
both private or public.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
