Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18732#discussion_r142529852
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2058,7 +2058,7 @@ def __init__(self, func, returnType, name=None, 
vectorized=False):
             self._name = name or (
                 func.__name__ if hasattr(func, '__name__')
                 else func.__class__.__name__)
    -        self._vectorized = vectorized
    +        self.vectorized = vectorized
    --- End diff --
    
    Oh sorry, I should have been more clear.  This should stay 
`self._vectorized` since it is a private variable to the class, it's only 
`wrapped.vectorized` (which you already changed below), isn't being used as 
private so shouldn't have an underscore.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to