Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18561868
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private val nextBroadcastId = new AtomicLong(0)
def newBroadcast[T: ClassTag](value_ : T, isLocal: Boolean) = {
- broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement())
+ broadcastFactory.newBroadcast[T](value_, isLocal,
nextBroadcastId.getAndIncrement)
--- End diff --
val i: AtomicLong = new AtomicLong(0)
i.incrementAndGet()
Code:
0: new #16 // class
java/util/concurrent/atomic/AtomicLong
3: dup
4: lconst_0
5: invokespecial #19 // Method
java/util/concurrent/atomic/AtomicLong."<init>":(J)V
8: astore_2
9: aload_2
10: invokevirtual #23 // Method
java/util/concurrent/atomic/AtomicLong.incrementAndGet:()J
13: pop2
14: return
val i: AtomicLong = new AtomicLong(0)
i.incrementAndGet
Code:
0: new #16 // class
java/util/concurrent/atomic/AtomicLong
3: dup
4: lconst_0
5: invokespecial #19 // Method
java/util/concurrent/atomic/AtomicLong."<init>":(J)V
8: astore_2
9: aload_2
10: invokevirtual #23 // Method
java/util/concurrent/atomic/AtomicLong.incrementAndGet:()J
13: pop2
14: return
they are same byte code.
scala recommend having no () if having no param
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
