Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19657#discussion_r149015420
  
    --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
    @@ -1183,3 +1183,24 @@ env | map
     ```{r, echo=FALSE}
     sparkR.session.stop()
     ```
    +
    +```{r cleanup, include=FALSE}
    +# clean up if Spark was downloaded
    +# get0 not supported before R 3.2.0
    +sparkDownloaded <- mget(".sparkDownloaded"[1L],
    --- End diff --
    
    yes! but both call sites are outside of the package technically and we 
would need to call the private function with `SparkR:::`, which is kinda ugly...
    
    I guess we could wrap the entire cleanup thing into a private/internal 
function (since it has to access a private flag anyway..)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to